11 #include "clang/AST/ASTContext.h"
12 #include "clang/ASTMatchers/ASTMatchFinder.h"
14 using namespace clang::ast_matchers;
20 switch (Node.getOverloadedOperator()) {
34 if (Node.isVariadic())
41 return Node.getNumParams() > 1;
42 if (Node.getNumParams() == 1)
49 if (Node.getNumParams() <= 1 || Node.getNumParams() > 2)
52 const auto *FPT = Node.getType()->castAs<FunctionProtoType>();
53 ASTContext &Ctx = Node.getASTContext();
54 if (Ctx.getLangOpts().SizedDeallocation &&
55 Ctx.hasSameType(FPT->getParamType(1), Ctx.getSizeType()))
66 OverloadedOperatorKind getCorrespondingOverload(
const FunctionDecl *FD) {
67 switch (FD->getOverloadedOperator()) {
74 return OO_Array_Delete;
78 llvm_unreachable(
"Not an overloaded allocation operator");
81 const char *getOperatorName(OverloadedOperatorKind K) {
85 return "operator new";
87 return "operator delete";
89 return "operator new[]";
91 return "operator delete[]";
93 llvm_unreachable(
"Not an overloaded allocation operator");
96 bool areCorrespondingOverloads(
const FunctionDecl *LHS,
97 const FunctionDecl *RHS) {
98 return RHS->getOverloadedOperator() == getCorrespondingOverload(LHS);
101 bool hasCorrespondingOverloadInBaseClass(
const CXXMethodDecl *MD,
102 const CXXRecordDecl *RD =
nullptr) {
105 for (
const auto *BMD : RD->methods())
106 if (BMD->isOverloadedOperator() && BMD->getAccess() != AS_private &&
107 areCorrespondingOverloads(MD, BMD))
113 RD = MD->getParent();
116 for (
const auto &BS : RD->bases()) {
119 if (BS.getType()->isDependentType())
121 if (
const auto *BaseRD = BS.getType()->getAsCXXRecordDecl())
122 if (hasCorrespondingOverloadInBaseClass(MD, BaseRD))
130 void NewDeleteOverloadsCheck::registerMatchers(MatchFinder *
Finder) {
131 if (!getLangOpts().CPlusPlus)
144 unless(anyOf(isImplicit(), isPlacementOverload(), isDeleted(),
145 cxxMethodDecl(isPrivate()))),
146 anyOf(hasOverloadedOperatorName(
"new"),
147 hasOverloadedOperatorName(
"new[]"),
148 hasOverloadedOperatorName(
"delete"),
149 hasOverloadedOperatorName(
"delete[]")))
154 void NewDeleteOverloadsCheck::check(
const MatchFinder::MatchResult &
Result) {
157 const auto *FD = Result.Nodes.getNodeAs<FunctionDecl>(
"func");
158 const CXXRecordDecl *RD =
nullptr;
159 if (
const auto *MD = dyn_cast<CXXMethodDecl>(FD))
160 RD = MD->getParent();
161 Overloads[RD].push_back(FD);
164 void NewDeleteOverloadsCheck::onEndOfTranslationUnit() {
169 SmallVector<const FunctionDecl *, 4> Diagnose;
170 for (
const auto &RP : Overloads) {
174 for (
const auto *Overload : RP.second) {
176 std::find_if(RP.second.begin(), RP.second.end(),
177 [&Overload](
const FunctionDecl *FD) {
182 if (FD->getDeclContext() != Overload->getDeclContext())
187 if (!areCorrespondingOverloads(Overload, FD))
193 if (Match == RP.second.end()) {
197 const auto *MD = dyn_cast<CXXMethodDecl>(Overload);
198 if (!MD || !hasCorrespondingOverloadInBaseClass(MD))
199 Diagnose.push_back(Overload);
204 for (
const auto *FD : Diagnose)
205 diag(FD->getLocation(),
"declaration of %0 has no matching declaration "
206 "of '%1' at the same scope")
207 << FD << getOperatorName(getCorrespondingOverload(FD));
std::unique_ptr< ast_matchers::MatchFinder > Finder
AST_MATCHER(Stmt, isInsideOfRangeBeginEndStmt)