11 #include "clang/AST/ASTContext.h"
12 #include "clang/ASTMatchers/ASTMatchFinder.h"
13 #include "clang/Lex/Lexer.h"
15 using namespace clang::ast_matchers;
20 void UniqueptrDeleteReleaseCheck::registerMatchers(MatchFinder *
Finder) {
21 auto IsSusbstituted = qualType(anyOf(
22 substTemplateTypeParmType(), hasDescendant(substTemplateTypeParmType())));
24 auto UniquePtrWithDefaultDelete = classTemplateSpecializationDecl(
25 hasName(
"std::unique_ptr"),
26 hasTemplateArgument(1, refersToType(qualType(hasDeclaration(cxxRecordDecl(
27 hasName(
"std::default_delete")))))));
31 has(cxxMemberCallExpr(on(expr(hasType(UniquePtrWithDefaultDelete),
32 unless(hasType(IsSusbstituted)))
34 callee(cxxMethodDecl(hasName(
"release"))))))
39 void UniqueptrDeleteReleaseCheck::check(
40 const MatchFinder::MatchResult &
Result) {
41 const auto *PtrExpr = Result.Nodes.getNodeAs<Expr>(
"uptr");
42 const auto *DeleteExpr = Result.Nodes.getNodeAs<Expr>(
"delete");
44 if (PtrExpr->getLocStart().isMacroID())
50 if (PtrExpr->getType()->isDependentType())
53 SourceLocation AfterPtr =
54 Lexer::getLocForEndOfToken(PtrExpr->getLocEnd(), 0, *Result.SourceManager,
55 Result.Context->getLangOpts());
57 diag(DeleteExpr->getLocStart(),
58 "prefer '= nullptr' to 'delete x.release()' to reset unique_ptr<> "
60 << FixItHint::CreateRemoval(CharSourceRange::getCharRange(
61 DeleteExpr->getLocStart(), PtrExpr->getLocStart()))
62 << FixItHint::CreateReplacement(
63 CharSourceRange::getTokenRange(AfterPtr, DeleteExpr->getLocEnd()),
std::unique_ptr< ast_matchers::MatchFinder > Finder